cvs commit: ports/graphics/xaos Makefile

[Kris Kennaway]

On Thu, Feb 26, 2004 at 08:46:48PM -0600, Peter Schultz wrote:

> >Set PTHREAD_LIBS='-DNOP -lpthread' PTHREAD_CFLAGS='-DNOP2' or similar
> >and verify that they're showing up correctly in the build log.
> >
> 
> I'm not getting the point of this.  If I `make -DWITH_THREADS' after 
> this patch, xaos is built and linked properly:
> 
> cc -DHAVE_SYS_PARAM_H  -I/usr/local/include  -pipe -O6 -fstrength-reduce 
> -ffast-math -fomit-frame-pointer -fforce-mem -fforce-addr -funroll-loops 
> -D_REENTRANT -I/usr/include/ncurses   -I/usr/X11R6/include 
> -I/usr/local/include  -I/usr/X11R6/include 
> -I/usr/ports/graphics/xaos/work/XaoS-3.0/src/include -L/usr/local/lib -o 
> /usr/ports/graphics/xaos/work/XaoS-3.0/bin/xaos lib/libui.a 
> lib/libengine.a  lib/libutil.a  lib/libfilter.a  lib/libuiaa.a 
> lib/libuix11.a -lpng -lz -lm -laa -lncurses -lpthread 
> -L/usr/X11R6/lib   -L/usr/X11R6/lib -lX11   -L/usr/X11R6/lib -lX11 
> -L/usr/local/lib -L/usr/local/lib -lXext   -L/usr/X11R6/lib -lX11
> 
> What is -DNOP?  Why doesn't textproc/libxml2 require this?

I mentioned -DNOP because it's a null operation that will have no
effect on the build, so you can easily verify from the build output
whether the port is using PTHREAD_CFLAGS and PTHREAD_LIBS for threaded
compilation and linking, or if it is hard-coding its own settings that
it thinks are correct for FreeBSD.  It might happen to be choosing
values that correspond to the current default settings in FreeBSD, but
if a user wants to override those defaults, or if FreeBSD changes the
defaults again, then it will be wrong.

Many ports do not correctly use PTHREAD_{CFLAGS,LIBS}, but that's no
reason to add another incorrect one.

Kris
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 187 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/cvs-ports/attachments/20040226/9df7d9c8/attachment.bin