cvs commit: ports/net/asterisk Makefile

[Maxim Sobolev]

Maxim Sobolev wrote:

> Kris Kennaway wrote:
> 
>> On Thu, Feb 19, 2004 at 04:25:43AM -0800, Maxim Sobolev wrote:
>>
>>> sobomax     2004/02/19 04:25:42 PST
>>>
>>>  FreeBSD ports repository
>>>
>>>  Modified files:
>>>    net/asterisk         Makefile  Log:
>>>  Revert previous delta, according to Porter's Handbook:
>>>  
>>>  http://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/porting-wrkdirprefix.html 
>>>
>>>  
>>>   "In particular, if you are referring to a WRKDIR of another port, 
>>> note that
>>>    the correct location is ${WRKDIRPREFIX}${PORTSDIR}/subdir/name/work"
>>>  
>>>  Other ports that use ${.CURDIR} when reffering WRKDIR of another 
>>> port should
>>>  be fixed along with bento scripts.
>>
>>
>>
>> Maxim, please take a deep breath and don't try and pick a fight here.
>> I'm quite happy to leave your port broken on bento if that's what you
>> want (too bad for any users who might have wanted to install the
>> package), but this commit isn't going to achieve anything else.
> 
> 
> No, please fix bento scripts so that they adhere to documented 
> behaviour. We should not make behaviour workaround bento's bugs and 
> false assumptions!

OK, after thinking its over, I've found a possible solution, which would 
allow to use documented ${WRKDIRPREFIX}${PORTSDIR} with /usr/ports 
symlinked to some other place, and will allow ports that reffer to 
WRKDIR of another port to be built outside of ${PORTSDIR}.

It is simple as:

Index: bsd.port.mk
===================================================================
RCS file: /home/pcvs/ports/Mk/bsd.port.mk,v
retrieving revision 1.484
diff -d -u -r1.484 bsd.port.mk
--- bsd.port.mk 4 Feb 2004 04:27:04 -0000       1.484
+++ bsd.port.mk 19 Feb 2004 17:25:44 -0000
@@ -1087,6 +1087,7 @@
  # tree we are and thus can't go relative.  They can, of course, be 
overridden
  # by individual Makefiles or local system make configuration.
  PORTSDIR?=             /usr/ports
+PORTSDIR!=             ${REALPATH} ${PORTSDIR}
  LOCALBASE?=            ${DESTDIR}/usr/local
  X11BASE?=              ${DESTDIR}/usr/X11R6
  LINUXBASE?=            ${DESTDIR}/compat/linux

I've tested it with symlinked /usr/ports and it appears to work just 
fine. Any objections to put it for testing on bento?

-Maxim