cvs commit: ports/irc/insub pkg-plist
adamw at magnesium.net
Fri Dec 17 15:02:29 PST 2004
Kris Kennaway wrote:
> On Fri, Dec 17, 2004 at 05:38:16PM -0500, Adam Weinberger wrote:
>>Alfred Perlstein wrote:
>>>* Adam Weinberger <adamw at magnesium.net> [041217 14:10] wrote:
>>>>Cowsay needs to be part of the RUN_DEPENDS anyway. Otherwise, you have a
>>>>bunch of cow files around with nothing that can use them. Besides,
>>>>cowsay isn't actually part of the build, anyway.
>>>>Furthermore, the @unexec rm %D/share/cows 2>/dev/null|| true should be
>>>>added to cowsay's pkg-plist, not insub's.
>>>Shall I do this?
>>I think so, yes. But cowsay belongs to Kris, and you should get approval
>>from him (*poke, poke, you're Cc:'ed*).
> If insub gains a dependency on cowsay (as it should), then nothing
> needs to be done to cowsay, because insub will be pkg_deleted before
> cowsay, and the share/cows directory will be empty by the time cowsay
> tries to remove it.
Right, but it means that every cowsay upgrade will barf error messages.
Which I thought is what the 2>/dev/null||true thing was there for.
adamw at magnesium.net || adamw at FreeBSD.org
adamw at vectors.cx || adamw at gnome.org
More information about the cvs-ports