cvs commit: ports/lang/pnet-base Makefile ports/lang/pnetlib Makefile

Kris Kennaway kris at obsecurity.org
Mon Apr 19 23:23:10 PDT 2004


On Mon, Apr 19, 2004 at 10:59:31PM -0700, Kirill Ponomarew wrote:
> krion       2004/04/19 22:59:31 PDT
> 
>   FreeBSD ports repository
> 
>   Modified files:
>     lang/pnet-base       Makefile 
>     lang/pnetlib         Makefile 
>   Log:
>   - Fix IGNORE message
>   - Remove quotes

> |  .if ${ARCH} == "alpha"
> | -BROKEN=		"cscc core dumps"
> | +BROKEN=		Coredump during build on alpha
> |  .endif

For these examples it was academic since they don't contain special
characters, but when they do then BROKEN needs to be quoted, and
IGNORE needs to be *not* quoted (because it is quoted internally by
bsd.port.mk).  I tried to repair this inconsistency a few weeks ago
because people (including myself) keep getting it wrong, but it was
hard to get all the cases to work and I haven't come back to it yet.

In the meantime it might be better to just remove all quotes from
IGNORE strings.

> |  .if ${ARCH} == "alpha"
> | -IGNORE=		"cscc core dumps durring build"
> | +IGNORE=		Coredump during build on alpha
> |  .endif

My point here was that IGNORE does this:

===>  pnetlib-0.6.4 Coredump during build on alpha.

which is not a properly formed sentence.

Kris
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 187 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/cvs-ports/attachments/20040419/a4694b27/attachment.bin


More information about the cvs-ports mailing list