(fwd) Re: cvs commit: ports/x11-toolkits/open-motif/files patch-lib::Xm::ColorS.c

[Kris Kennaway]

On Mon, Jul 14, 2003 at 11:29:11AM +0200, Volker Stolz wrote:
> On Mon, Jul 14, 2003 at 09:22:36AM +0200, Alexander Langer wrote:
> > ----- Forwarded message from Kris Kennaway <kris at obsecurity.org> -----
> > >   'colordemo' from open-motif can be used to select colors by either RGB values
> > >   or from the file rgb.txt. However, the underlying library doesn't honour XBASE
> > >   and looks for the file in the wrong place.
> > >   
> > Are you sure this patch is correct?  How does X11BASE get transmuted
> > into LIBDIR (which defaults to /usr/lib)?
> 
> LIBDIR gets set in the Makefile by means of configure and is handled in the same
> way in similar places throughout the source, e.g. openmotif-2.2.2/lib/Xm/Xmos.c
> I added the #ifndef LIBDIR lines so that in case somebody else picks up our patches or
> chooses to configure this thing in a different way, he gets the behaviour of the
> original source code. Notice the -DLIBDIR in the actual command being executed from the
> FreeBSD port:
> 
> cc -DHAVE_CONFIG_H -I. -I. -I../../include -I./.. -DXMBINDDIR_FALLBACK=\"/usr/X11R6/lib/X11/bindings\" -DINCDIR=\"/usr/X11R6/include/X11\" -DLIBDIR=\"/usr/X11R6/lib/X11\" -I/usr/X11R6/include -DCSRG_BASED -DXUSE_MTSAFE_API -DXNO_MTSAFE_PWDAPI -O -pipe -O -pipe -W -march=pentiumpro -Wall -Wno-unused -Wno-comment -c ColorS.c  -fPIC -DPIC -o .libs/ColorS.lo
> 
> Do you see a specific case where this breaks?

OK, that looks fine.  I didn't see LIBDIR being set in the port
makefile or patches, so I assumed that the configure script wouldn't
set it to a different default value than that used in the source.

Kris
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 187 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/cvs-ports/attachments/20030714/74e41fd0/attachment.bin