cvs commit: doc/en_US.ISO8859-1/books/arch-handbook/driverbasics chapter.sgml

[Florent Thoumie]

Chin-San Huang wrote:
> chinsan     2007-07-16 13:55:59 UTC
> 
>   FreeBSD doc repository
> 
>   Modified files:
>     en_US.ISO8859-1/books/arch-handbook/driverbasics chapter.sgml 
>   Log:
>   - According to the module(9) man page, the return value for
>     unrecognized values is EOPNOTSUPP, not EINVAL.
>   
>   Noticed by:     kevlo

Using both EINVAL and EOPNOTSUPP makes sense to me. In the arch-handbook
code snippet we return EOPNOTSUPP whether what is MOD_QUIESCE or an
invalid value.

I understand it's done that way for simplicity's sake (instead of adding
a case statement for unsupported operations and default to return
EINVAL), but there's an inconsistency with module(9).

It currently says:

"The module should return EOPNOTSUPP for unrecognized values of what"

Maybe something like the following would be better:

"The module should return EOPNOTSUPP for unsupported and unrecognized
values of what."

-- 
Florent Thoumie
flz at FreeBSD.org
FreeBSD Committer

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 250 bytes
Desc: OpenPGP digital signature
Url : http://lists.freebsd.org/pipermail/cvs-doc/attachments/20070716/c58cbc43/signature.pgp