cvs commit: doc/en_US.ISO8859-1/books/arch-handbook/driverbasics chapter.sgml

Marc Fonvieille blackend at FreeBSD.org
Thu Sep 25 09:41:32 PDT 2003


On Thu, Sep 25, 2003 at 12:24:28PM -0400, Ken Smith wrote:
> > is there a special reason why we do this here?
> 
> In this case there is a special reason - the whitespace adjustments
> are visible to the users.  I was adjusting whitespace inside of
> a program example.  Someone else mentioned this as well, I was
> making it style(9) compliant.  IMO if the people who watch over
> the source code commits are going to "insist" on style(9) compliance
> we should make an effort for the examples in the online documentation
> to also be style(9) compliant.
> 
> Should I phrase the commit log message in a different way if this
> sort of thing happens again?  Strictly speaking because the whitespace
> changes are visible in the end result you could consider this a real
> functional change.  People tend to associate "whitespace change"
> with "will be eaten by the SGML processors and makes no visible
> change in the end result" but in cases like this that is not the case.
>

You were explicit enough IMHO in your log message.
Heh no one noted you tested the driver code on a shinny sparc64! :))

Marc


More information about the cvs-doc mailing list