cvs commit: doc/en_US.ISO8859-1/books/arch-handbook/driverbasics chapter.sgml

Maxime Henrion mux at freebsd.org
Thu Sep 25 08:46:04 PDT 2003


Josef El-Rayes wrote:
> Ken Smith <kensmith at FreeBSD.org> wrote:
> > - "whitespace change" that coverts existing driver example code
> > to be style(9) compliant, matching format of new driver code
> 
> for me this is strange, i always thought that we do not do patches which
> do whitespace changes only - which does make the repository bigger
> without any real benefit.

Not really - what is most important is to not mix functional changes and
whitespace changes touching different parts of the code in a single commit
since it makes the diff much harder to read.  Bearing this in mind, when
you want a file to be style(9) compliant, you sometimes have to bite the
bullet and commit whitespace changes only.  I usually do this before
heavily modifying a file, making it style(9) compliant before doing
anything else.  This way, I'm not tempted to fix style(9) bugs when doing
functional changes and I keep the functional changes commit clean.

Cheers,
Maxime


More information about the cvs-doc mailing list