cvs commit: ports/archivers/unrar Makefile

[Yar]

Hello Poyopoyo,

Saturday, January 14, 2012, 7:20:45, you wrote:

> At Sun, 8 Jan 2012 09:30:33 +0000 (UTC),
> Sunpoet Po-Chuan Hsieh wrote:
>> @@ -24,6 +24,9 @@ MAKEFILE=     makefile.unix
>>  PLIST_FILES=   bin/unrar
>>  PORTDOCS=      license.txt readme.txt
>> 
>> +post-patch:
>> +       @${REINPLACE_CMD} -e '/^CXX/ s|^|#|' ${WRKSRC}/${MAKEFILE}
>> +
>>  do-install:
>>         ${INSTALL_PROGRAM} ${WRKSRC}/unrar ${PREFIX}/bin
>>  .if !defined(NOPORTDOCS)

> Hi,
> Commenting CXX* out after patch phase breaks unrar-iconv since it
> requires CXXFLAGS to be set in makefile.unix.

===>>  Building for unrar-iconv-4.10,5
> c++  -O2 -pipe -march=native -fno-strict-aliasing
> -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -DWITH_ICONV -DUNRAR -c rar.cpp
> In file included from rar.hpp:5,
>                  from rar.cpp:1:
> os.hpp:197:19: error: iconv.h: No such file or directory
> In file included from rar.hpp:76,
>                  from rar.cpp:1:
> global.hpp:19: error: 'iconv_t' does not name a type
> global.hpp:20: error: 'iconv_t' does not name a type
> gmake: *** [rar.o] Error 1
> *** Error code 1

> Here's a candidate:
> - Comment CXX* out for only unrar not for unrar-iconv.
I  vote  for it! \if !defined(USE_ICONV) at unrar Makefile\.
It's more accuracy at my point of view.

> - in unrar-iconv do the same thing with files/patch-iconv.
BUT :) I attached tiny patch for unrar-iconv/Makefile
with dirty workaround.



-- 
Best regards,
 Yar                          mailto:yarodin at gmail.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: unrar-iconv_Makefile.patch
Type: application/octet-stream
Size: 376 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/cvs-all/attachments/20120115/1d628f00/unrar-iconv_Makefile.obj