cvs commit: ports/lang/lua Makefile

[Chris Rees]

On 7 Nov 2011 07:46, "Jan Beich" <jbeich at tormail.net> wrote:
>
> Renato Botelho <garga at FreeBSD.org> writes:
>
> >   FreeBSD ports repository
> >
> >   Modified files:
> >     lang/lua             Makefile
> >   Log:
> >   - Remove gmake as a dependency, it's not necessary
>
> This breaks empty CFLAGS from make.conf. Try
>
>  $ echo CFLAGS= >>/etc/make.conf
>  $ make
>  cc  -Wall -DLUA_USE_LINUX -c lapi.c
>  [...]
>  cc -o liblua.so  -Wall -DLUA_USE_LINUX   -shared
-Wl,-soname=liblua-5.1.so.1 lapi.o lcode.o ldebug.o ldo.o ldump.o lfunc.o
lgc.o llex.o lmem.o lobject.o lopcodes.o lparser.o lstate.o lstring.o
ltable.o ltm.o lundump.o lvm.o lzio.o lauxlib.o lbaselib.o ldblib.o
liolib.o lmathlib.o loslib.o ltablib.o lstrlib.o loadlib.o linit.o
>  /usr/bin/ld: lapi.o: relocation R_X86_64_32S against `luaO_nilobject_'
can not be used when making a shared object; recompile with -fPIC
>  lapi.o: could not read symbols: Bad value
>  *** Error code 1
>
> Here is a workaround that prevents multipass reading of make.conf.
> ref. http://docs.freebsd.org/cgi/mid.cgi?864odkh7vz.fsf
>     commit log for lang/lua/Makefile at r1.43
>
> Index: lang/lua/Makefile
> ===================================================================
> RCS file: /a/.csup/ports/lang/lua/Makefile,v
> retrieving revision 1.46
> diff -u -p -r1.46 Makefile
> --- lang/lua/Makefile   4 Nov 2011 20:01:16 -0000       1.46
> +++ lang/lua/Makefile   6 Nov 2011 10:27:23 -0000
> @@ -26,7 +26,7 @@ ALL_TARGET=   freebsd
>  USE_GNOME=     pkgconfig
>  USE_LDCONFIG=  yes
>  MAKE_JOBS_SAFE=        yes
> -MAKE_ENV=      LUA_SONAME="liblua-${LUA_VER}.so.${LUA_VER_SH}"
> +MAKE_ENV=      __MAKE_CONF=
LUA_SONAME="liblua-${LUA_VER}.so.${LUA_VER_SH}"
>
>  MAN1=          lua-${LUA_VER}.1 luac-${LUA_VER}.1
>  DOCSDIR=       ${PREFIX}/share/doc/${LUA_SUBDIR}

CFLAGS should not be set in make.conf.

Chris