cvs commit: ports/editors/emacs-devel Makefile distinfo
ashish at freebsd.org
Sun May 1 04:45:37 UTC 2011
Pan Tsu writes:
> ashish at freebsd.org (Ashish SHUKLA) writes:
>> Pan Tsu writes:
>>> - Any reason to use autogen.sh instead of relying on AUTOTOOLS?
>> Because autogen.sh works fine, and is provided by the upstream to configure
>> the sources. So, I prefer to use upstream, unless it behaves badly.
> It makes sure autotools use and dependencies are tracked properly by the
> ports framework. For example, autoreconf (from autogen.sh) invokes
> autoheader which you did not specify in AUTOTOOLS.
Although, at the moment, it's implicitly included as autoconf is also provided
by same package, but I guess explicitly mentioning it is better way. So, I'll
append "autoheader:env" to USE_AUTOTOOLS, as well.
>>> - Why patch-src_config.in was lost and not converted to patch-configure.in?
>> As I see, in src/config.in (excerpt is pasted below) which get generated
>> already includes "stdlib.h", so I don't see any need of the re-including it,
>> unless you think it causes some issue.
> Including stdlib.h makes sure both alloca(3) and _STDLIB_H_ are defined
> at that point and no prior or future explicit inclusion of stdlib.h
> redefines it. The warning described ports/149049 is still present
Sorry about this :(. Thanks for the explanations, and checks you carried out.
I'll include the changes and commit them.
Ashish SHUKLA | GPG: F682 CDCC 39DC 0FEA E116 20B6 C746 CFA9 E74F A4B0
freebsd.org!ashish | http://people.freebsd.org/~ashish/
Avoid Success At All Costs !!
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 833 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/cvs-all/attachments/20110501/d51c1f68/attachment.pgp
More information about the cvs-all