cvs commit: ports/lang/php52 Makefile

[Julien Laffaye]

On 06/30/2011 04:20, Sahil Tandon wrote:
> On Wed, 2011-06-29 at 19:51:17 +0000, Julien Laffaye wrote:
> 
>>   Modified files:
>>     lang/php52           Makefile 
>>   Log:
>>   Add an option to link against libthr
>>   
>>   PR:             ports/158423
>>   Submitted by:   Frank Wall <fw at moov.de>
>>   Approved by:    Alex Keda <admin at lissyara.su> (maintainer), bapt (mentor, implicit)
>>   
>>   Revision  Changes    Path
>>   1.18      +7 -1      ports/lang/php52/Makefile
> 
> Why bump PORTREVISION if the new option is off by default and does not
> affect the default package?  This is sometimes a grey area, so please do
> not misconstrue my question for hostility; I just want to understand
> your rationale.  For context, ale@ added the LINKTHR option to lang/php5
> last year without a bump:
> 
> http://www.freebsd.org/cgi/cvsweb.cgi/ports/lang/php5/Makefile.diff?r1=1.147;r2=1.148
> 

I could have sworn that I removed it after applying the PR patch.
Apparently that was not the case :( Sorry for that.