cvs commit: ports/net/erlyvideo Makefile pkg-plist

Wesley Shields wxs at FreeBSD.org
Thu Jun 2 16:54:02 UTC 2011


On Thu, Jun 02, 2011 at 04:31:42PM +0000, Pav Lucistnik wrote:
> pav         2011-06-02 16:31:42 UTC
> 
>   FreeBSD ports repository
> 
>   Modified files:
>     net/erlyvideo        Makefile pkg-plist 
>   Log:
>   - Fix plist
>   
>   Submitted by:   Ruslan Mahmatkhanov <cvs-src at yandex.ru> (maintainer)
>   
>   Revision  Changes    Path
>   1.7       +2 -0      ports/net/erlyvideo/Makefile
> http://cvsweb.FreeBSD.org/ports/net/erlyvideo/Makefile.diff?r1=1.6&r2=1.7
> | --- ports/net/erlyvideo/Makefile	2011/05/31 02:45:34	1.6
> | +++ ports/net/erlyvideo/Makefile	2011/06/02 16:31:42	1.7
> | @@ -2,11 +2,12 @@
> |  # Date created:                         14 January 2011
> |  # Whom:                                 Ruslan Mahmatkhanov <cvs-src at yandex.ru>
> |  #
> | -# $FreeBSD: /usr/local/www/cvsroot/FreeBSD/ports/net/erlyvideo/Makefile,v 1.6 2011/05/31 02:45:34 miwi Exp $
> | +# $FreeBSD: /usr/local/www/cvsroot/FreeBSD/ports/net/erlyvideo/Makefile,v 1.7 2011/06/02 16:31:42 pav Exp $
> |  #
> |  
> |  PORTNAME=	erlyvideo
> |  PORTVERSION=	2.8.1
> | +PORTREVISION=	1
> |  CATEGORIES=	net
> |  MASTER_SITES=	http://host5.webstroy.ru/
> |  
> | @@ -39,6 +40,7 @@ post-patch:
> |  		${WRKSRC}/priv/${PORTNAME}.conf.sample
> |  	@${FIND} ${WRKSRC} -type f -name .gitignore | ${XARGS} ${RM}
> |  	@${FIND} ${WRKSRC} -type f -name "*.bak" | ${XARGS} ${RM}
> | +	@${FIND} ${WRKSRC} -type f -name "*.orig" | ${XARGS} ${RM}
> |  	@${RMDIR} ${WRKSRC}/src/plugins

I understand Ruslan was just following the convention used in this port
but I don't like this construct. We should at least be doing -print0 |
xargs -0 if we are going to be using xargs like this. I, personally,
would prefer us to use the -delete option to find.

I wonder if there are other places in the ports tree where a similar
construct can be found that we should also cleanup.

-- WXS


More information about the cvs-all mailing list