cvs commit: ports/multimedia/mencoder Makefile

[Philip M. Gollucci]

On 07/23/11 20:13, Doug Barton wrote:
> On 07/22/2011 23:07, b. f. wrote:
> 
>> I must renew my plea to avoid these "fixes".  When a user sets
>> WITH/WITHOUT_FOO, he means precisely "build this port
>> WITH/WITHOUT_FOO", and not "build this port WITH/WITHOUT_FOO, except
>> if package X is installed, and, if it is, silently do something else",
>> and we should not be adding code to do the latter. We should instead
>> patch the broken distribution configure scripts and Makefiles, so that
>> the problem does not occur.  If a lack of time or another problem
>> prevents this from being done initially, then as a temporary
>> workaround, we should add something like:
>>
>> .if exists(${LOCALBASE}/lib/libass.so) && defined(WITHOUT_ASS)
>> BROKEN= libass is installed, so broken mplayer scripts will ignore WITHOUT_ASS
>> .endif
>>
>> so that the user will know that his choice of options cannot be used,
>> and he can take the appropriate action -- and he will not be misled
>> into thinking that his choice of options are used when they are not.
> 
> +1
> 
Yes, I agree violently too.  I even remember removing about 10
occurrences in the past.


-- 
------------------------------------------------------------------------
1024D/DB9B8C1C B90B FBC3 A3A1 C71A 8E70  3F8C 75B8 8FFB DB9B 8C1C
Philip M. Gollucci (pgollucci at p6m7g8.com) c: 703.336.9354
VP Infrastructure,                Apache Software Foundation
Committer,                        FreeBSD Foundation
Consultant,                       P6M7G8 Inc.
Sr. System Admin,                 Ridecharge Inc.

Work like you don't need the money,
love like you'll never get hurt,
and dance like nobody's watching.