cvs commit: ports/multimedia/mencoder Makefile

[Doug Barton]

On 07/22/2011 23:07, b. f. wrote:

> I must renew my plea to avoid these "fixes".  When a user sets
> WITH/WITHOUT_FOO, he means precisely "build this port
> WITH/WITHOUT_FOO", and not "build this port WITH/WITHOUT_FOO, except
> if package X is installed, and, if it is, silently do something else",
> and we should not be adding code to do the latter. We should instead
> patch the broken distribution configure scripts and Makefiles, so that
> the problem does not occur.  If a lack of time or another problem
> prevents this from being done initially, then as a temporary
> workaround, we should add something like:
> 
> .if exists(${LOCALBASE}/lib/libass.so) && defined(WITHOUT_ASS)
> BROKEN= libass is installed, so broken mplayer scripts will ignore WITHOUT_ASS
> .endif
> 
> so that the user will know that his choice of options cannot be used,
> and he can take the appropriate action -- and he will not be misled
> into thinking that his choice of options are used when they are not.

+1

-- 

	Nothin' ever doesn't change, but nothin' changes much.
			-- OK Go

	Breadth of IT experience, and depth of knowledge in the DNS.
	Yours for the right price.  :)  http://SupersetSolutions.com/