cvs commit: ports/dns/opendnssec Makefile distinfo pkg-plist ports/dns/opendnssec/files opendnssec.in

Jaap Akkerhuis jaap at NLnetLabs.nl
Mon Jul 18 09:06:47 UTC 2011


Hi Doug,
    
    I've attached some (hopefully) improvements to the rc.d script. First
    the minor issues:
    
    1. It needs a $FreeBSD$

Oops, didn't realise that.

    2. We prefer ports scripts to REQUIRE: LOGIN unless there is a reason it
    needs to start earlier.

Yes, I was wondering whether I should do that or not.

    3. Minor typo and whitespace twiddles
    
    More substantively, I compressed the start_ and stop_ methods, but this
    should be tested. It certainly _should_ work. :) It's fine to have all
    the extra_commands, but they won't be functional unless they also have
    methods associated with them. Finally, I left the procname assignment in
    there, but it's not at all clear to me where $opendnssec_procname is
    defined, or what that procname is going to be used for. It can probably
    just be deleted.
    
Thanks a bunch. I'll test this out to be sure. Yes you might have
guessed, I incoporated this from a user who apparently based this
on the nsd rc.d script. I'll have a look at that one as well.

	jaap



More information about the cvs-all mailing list