cvs commit: ports/sysutils/tmux Makefile ports/sysutils/tmux/files extra-patch-configure

[Gary Jennejohn]

On Tue, 11 Jan 2011 05:58:45 +0000
Alexey Dokuchaev <danfe at FreeBSD.org> wrote:

> On Tue, Jan 11, 2011 at 08:03:40AM +0800, wen heping wrote:
> > 2011/1/11 Boris Samorodov <bsam at ipt.ru>:
> > > On Mon, 10 Jan 2011 06:52:10 +0000 Alexey Dokuchaev wrote:
> > >> On Sun, Jan 09, 2011 at 11:18:48PM -0500, Sahil Tandon wrote:
> > >> >
> > >> > http://lists.freebsd.org/pipermail/freebsd-ports/2010-March/060003.html
> > >
> > >> Kudos to gj@ for his investigation; I hope clueful guys will eventually
> > >> solve the problem properly. But commit message could be improved
> > >> considerably if it included that text from ports@ at least partially.
> > >> This would save the list from my stupid questions, and interested folks
> > >> might decide to help Gary and Andriy fixing this issue.
> > >
> > > Well, after that commit the port is broken: freezes in minutes:
> > > [...]
> > 
> > I agree commit message should include more message of the run error to
> > help others resolve the problem.  But: some days ago, garga@ send me
> > a mail with a scipts written by him to confirm me there would be run error
> > if tmux build with kqueue on some special platform. I think it is not easy
> > to include this message in serveral lines in commit log.
> 
> I haven't seen the message sent to you by garga@, but for example for
> the above analysis given by gj@ I think approprite shorter message could
> be:
> 
>   Disable kqueue support for now; apparently, devel/libevent thinks our
>   kqueue(2) implementation is broken: it assumes that kevent() will
>   always return 1 on success.  According to kqueue(2) kevent will return
>   up to nevents on success.
> 
>   Analyzed by:	gj@
> 
> When in doubt, there is community to ask.  :-)
> 

I actually changed libevent to check for <= 0 when calling kevent()
and then installed tmux.  My tmux *does* use libevent.

Unfortunately, my tmux also shows the hang problem reported by Boris
Samorodov, and I'm running 9-current.  However, I only see the hang
on the console after closing the last-to-one pane in tmux, i.e. only
one pane remains active.  When multiple panes are active I observe no
problems.

I also haven't noticed any problem at all when I run tmux in mrxvt.
There I can create and close panes without any hangs.  But I only
did limited testing with mrxvt.

-- 
Gary Jennejohn (gj@)