cvs commit: ports/graphics/freeimage Makefile distinfo pkg-descr ports/graphics/freeimage/files patch-Source-LibOpenJPEG_opj_malloc.h

[Peter Jeremy]

On 2011-Jan-04 10:27:47 +0100, Pietro Cerutti <gahr at gahr.ch> wrote:
>Well I tend to disagree here. I see a commit message as a way to convey
>important notes about a commit.

And I see a commit message as explaining _why_ the change was made.

>I would like to avoid to have to write a line like this
>
>- add a patch file to fix an include line that used the deprecated
>  header alloc.h instead of stdlib.h
>
>for a patch file like this
>
>- #include <alloc.h>
>+ #include <stdlib.h>

OTOH, I would like to see such a patch file documented along the lines of:

- Patch to replace deprecated alloc.h with stdlib.h

(But I wouldn't make fuss if it was skipped).

-- 
Peter Jeremy
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 196 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/cvs-all/attachments/20110106/6158edfe/attachment.pgp