cvs commit: ports/net Makefile ports/net/iet Makefile distinfo pkg-descr pkg-plist ports/net/iet/files ietd.in

[Doug Barton]

There are numerous problems with the rc.d script in this port. Please 
see 
http://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/rc-scripts.html 
for more information. The biggest problem (that must be fixed, along 
with a PORTREVISION bump) is that it doesn't have a default value for 
_enable. The other problems are that it's not clear why REQUIRE and 
BEFORE are set the way they are. We prefer ports scripts to simply 
REQUIRE: LOGIN, but if there is a good reason to run this script as is 
that's fine. There is also no $FreeBSD$ line. The attached script sorts 
things out in a more standard way.


hth,

Doug


On 02/25/2011 20:58, Xin LI wrote:
> delphij     2011-02-26 04:58:37 UTC
>
>    FreeBSD ports repository
>
>    Modified files:
>      net                  Makefile
>    Added files:
>      net/iet              Makefile distinfo pkg-descr pkg-plist
>      net/iet/files        ietd.in
>    Log:
>    iSCSI Enterprise Target, based on a original port by QuadStor Systems [1].
>
>    iSCSI Enterprise Target is a simple open source iSCSI target with
>    professional features, that works well in enterprise environments
>    under real workloads, and is scalable and versatile enough to meet
>    the challenge of future storage needs and developments.
>
>    Part of additional work was sponsored by iXsystems, Inc.
>
>    [1] http://www.quadstor.com/tech-articles/116-iscsi-enterprise-target-iet-on-freebsd.html
>
>    Revision  Changes    Path
>    1.2316    +1 -0      ports/net/Makefile
>    1.1       +52 -0     ports/net/iet/Makefile (new)
>    1.1       +4 -0      ports/net/iet/distinfo (new)
>    1.1       +21 -0     ports/net/iet/files/ietd.in (new)
>    1.1       +8 -0      ports/net/iet/pkg-descr (new)
>    1.1       +21 -0     ports/net/iet/pkg-plist (new)
>
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/net/Makefile.diff?&r1=1.2315&r2=1.2316&f=h
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/net/iet/Makefile
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/net/iet/distinfo
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/net/iet/files/ietd.in
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/net/iet/pkg-descr
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/net/iet/pkg-plist
>



-- 

	Nothin' ever doesn't change, but nothin' changes much.
			-- OK Go

	Breadth of IT experience, and depth of knowledge in the DNS.
	Yours for the right price.  :)  http://SupersetSolutions.com/

-------------- next part --------------
#!/bin/sh

# $FreeBSD$
#
# PROVIDE: ietd 
# REQUIRE: NETWORKING SERVERS DAEMON ldconfig resolv
# BEFORE: LOGIN
# KEYWORD: shutdown

. /etc/rc.subr

name="ietd"
rcvar=`set_rcvar`

command=%%PREFIX%%/sbin/${name}
required_modules="iet"
stop_precmd="ietd_prestop"

load_rc_config $name

: ${ietd_enable:="NO"}

ietd_prestop()
{
	%%PREFIX%%/sbin/ietadm --op delete
}

run_rc_command "$1"