cvs commit: ports/www/hiawatha Makefile ports/www/hiawatha/files hiawatha.in php-fcgi.in pkg-message.in

Doug Barton dougb at FreeBSD.org
Tue Aug 23 20:13:02 UTC 2011


The rc.d script looks good, thanks!

The only thing I would do differently is instead of having 2 separate lines:

: ${hiawatha_pidfile="/var/run/hiawatha.pid"}
pidfile=${hiawatha_pidfile}

Do it like this:

pidfile=${hiawatha_pidfile="/var/run/hiawatha.pid"}

But that's really a micro-optimization.


Thanks again,

Doug


On 08/23/2011 13:03, Greg Larkin wrote:
> glarkin     2011-08-23 20:03:35 UTC
> 
>   FreeBSD ports repository
> 
>   Modified files:
>     www/hiawatha         Makefile 
>     www/hiawatha/files   hiawatha.in pkg-message.in 
>   Added files:
>     www/hiawatha/files   php-fcgi.in 
>   Log:
>   - Added rc.d file for php-fcgi (Hiawatha FastCGI daemon)
>   - Cleanups in hiawatha rc.d file
>   - Bumped PORTREVISION
>   
>   PR:             ports/158944  http://www.FreeBSD.org/cgi/query-pr.cgi?pr=158944
>   Submitted by:   C-S <c-s at c-s.li> (maintainer)
>   
>   Revision  Changes    Path
>   1.32      +2 -1      ports/www/hiawatha/Makefile
>   1.3       +19 -7     ports/www/hiawatha/files/hiawatha.in
>   1.1       +36 -0     ports/www/hiawatha/files/php-fcgi.in (new)
>   1.5       +3 -0      ports/www/hiawatha/files/pkg-message.in
> 
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/www/hiawatha/Makefile.diff?&r1=1.31&r2=1.32&f=h
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/www/hiawatha/files/hiawatha.in.diff?&r1=1.2&r2=1.3&f=h
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/www/hiawatha/files/php-fcgi.in
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/www/hiawatha/files/pkg-message.in.diff?&r1=1.4&r2=1.5&f=h
> 



-- 

	Nothin' ever doesn't change, but nothin' changes much.
			-- OK Go

	Breadth of IT experience, and depth of knowledge in the DNS.
	Yours for the right price.  :)  http://SupersetSolutions.com/



More information about the cvs-all mailing list