cvs commit: ports/polish/kadu Makefile distinfo pkg-descr pkg-plist ports/polish/kadu/files patch-kadu-core__CMakeLists.txt patch-kadu-core_gadu_resolver.cpp patch-modules__docking__CMakeLists.txt patch-modules__idle__CMakeLists.txt patch-modules__kde_notify__CMakeLists.txt patch-modules__screenshot__CMakeLists.txt patch-modules__sound__CMakeLists.txt ...

[Doug Barton]

On 08/22/2011 19:08, Alexey Dokuchaev wrote:
> On Mon, Aug 22, 2011 at 06:21:11PM +0000, Pawel Pekala wrote:
>> pawel       2011-08-22 18:21:11 UTC
>>
>>   Log:
>>   - unbreak and update to version 0.9.2
>>   - add LICENSE info
>>   - mark MAKE_JOBS_UNSAFE
>>   - remove WITH_TABS option, now included in main package
>>   - take maintainership
> 
> Still some issues with this port:
> 
> - First part of the makefile (delarative one) is badly indented; indentation
>   should be reduced my one tabstop
> 
> - Bad spelling of Qt toolkit in COMMENT (it looks like port is QuickTime
>   based now); also, " / " does not look too good, simple "and" would look
>   better
> 
> %%%
>  LIB_DEPENDS=		enchant.1:${PORTSDIR}/textproc/enchant \
>  			gadu.3:${PORTSDIR}/polish/libgadu \
> +			idn:${PORTSDIR}/dns/libidn \
>  			qca.2:${PORTSDIR}/devel/qca \
>  			sndfile.1:${PORTSDIR}/audio/libsndfile
> %%%
> 
> Missing shlib version (notice that other libs have it).  While it
> technically not required, it's nice to have to be able to grep for when
> buming port revision of library consumer ports to chase shlib version
> bumps.

The version should only be specified for dependents that are tied to a
specific version. If the dependent can survive a version bump of the lib
then the dependency should be specified without version, and NOT bumped
when the lib is updated.


Doug

-- 

	Nothin' ever doesn't change, but nothin' changes much.
			-- OK Go

	Breadth of IT experience, and depth of knowledge in the DNS.
	Yours for the right price.  :)  http://SupersetSolutions.com/