cvs commit: ports/sysutils/zfsnap Makefile distinfo

Bernhard Froehlich decke at FreeBSD.org
Thu Sep 30 12:21:08 UTC 2010


On Thu, 30 Sep 2010 02:11:01 -0700, Stanislav Sedov <stas at FreeBSD.org>
wrote:
> On Thu, 30 Sep 2010 10:54:55 +0200
> Pav Lucistnik <pav at FreeBSD.org> mentioned:
> 
>> >
>> > It's usually beneficial if you also provide the short changelog of changes
>> > in the software, or at least a link to the changelog.  Especially in this
>> > case, when maintainer wrote it clearly in the PR.
>>
>> It's not an usual practice.
>>
> 
> Unfortunately.  But it's a good one to follow, and we used to do this some
> time ago.

In this special case it could be beneficial because the submitter is
also the author of the project and I couldn't find the changelog
anywhere after a short search. Sorry for that.

>> Again, it's not a usual practice to have this in the Makefiles so the
>> cleanup is understandable.
> 
> I understand the cleanup reason, and actually all hands for this, but
> the change should be mentioned in the commit message.

Okay, I will also mention such tiny changes in the future.

-- 
Bernhard Froehlich
http://www.bluelife.at/


More information about the cvs-all mailing list