cvs commit: ports/archivers/p5-Archive-Any pkg-plist ports/archivers/p5-Archive-SimpleExtractor pkg-plist ports/archivers/p5-Compress-LZF pkg-plist ports/archivers/p5-Compress-LZO pkg-plist ports/archivers/p5-Compress-LZW pkg-plist ports/archiver

Doug Barton dougb at FreeBSD.org
Fri Sep 24 07:27:31 UTC 2010


On 9/24/2010 12:18 AM, Sergey A. Osokin wrote:
> On Fri, Sep 24, 2010 at 12:01:47AM -0700, Doug Barton wrote:
>> On 9/23/2010 10:39 PM, Andrej Zverev wrote:
>>>       Log:
>>>       - only 13% of the p5- ports embed @comment $FreeBSD$:
>>>         so standarize and remove it
>>>
>>> How about to explain the benefits of this?
>>
>> Speaking only for myself ...
>>
>> 1. Standardization is a good thing since so much stuff is copy/pasted
>
> Could you please describe standards and vote before doing anything.  Thank you.

I think Philip described the standard very well in the portion of the 
log that is quoted above. Personally, I've never seen or used such a 
comment in any FreeBSD port, and can't imagine any reason why someone 
would want to.

>> 2. The comments that were removed added no value, so
>
> This commit also have no additional value too.  Thank you again.

It made the ports tree a little smaller? And personally I think more 
standardization is a good thing in areas that have no material effect on 
the port, or the maintainer's creativity.

>> 3. There was no harm in removing them.
>>
>> Philip may have additional/better answers.
>> Do you have a specific concern about them being removed, or were you
>> just curious?
>
> I'm totally disagree with Philip mass-commits as well as implicit approval from portmgrs.

This sounds to me like a personality and/or perspective problem, more 
than a technical one. If you'd like to raise a _technical_ issue with 
the commit (as in, something that worked previously no longer does) then 
this list is probably the right one to do that.

If you have a personality or other non-technical issue, perhaps you'd be 
better off raising it privately, or with portmgr at .


FWIW,

Doug

-- 

	... and that's just a little bit of history repeating.
			-- Propellerheads

	Improve the effectiveness of your Internet presence with
	a domain name makeover!    http://SupersetSolutions.com/



More information about the cvs-all mailing list