cvs commit: ports/devel/rubygem-pkg-config pkg-descr

[Steve Wills]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Here's a draft of a reply... I'd appreciate comments before I send it...

Thanks,
Steve


On 10/14/10 18:39, Stanislav Sedov wrote:
> On Thu, 14 Oct 2010 17:51:17 -0400
> Wesley Shields <wxs at FreeBSD.org> mentioned:
> 
> 
> But you didn't heard that you should use 'co-mentor' either?

Actually, I did, from my mentor. I can't find the mail right now to
forward, but I'm pretty sure I didn't imagine it.`

> It was meant for consistency, so you can later do some automatic processing
> based on "(mentor)".  I don't even know where this string came from: you
> probably can't find any references to "approved by co-mentor" neither in
> the committer's guide, or in porter's handbook.
> 
> I just was surpised to receive no reaction on my first comment both from the
> committer and the mentor: the "co-mentor" nonsense has continued to be used.
> Maybe I just missed that, but I didn't heard that we allow each new mentor
> to invent his own string to put into parenthesis; if it's true, my I'll
> ask my next mentee to put something like "master" or "god" in place of
> "mentor", just because I like it better, or nobody told me that I shouldn't
> do that.
> 

As far as the other points go:

1. I fixed the WWW link as you saw.

2. The package docs and Rakefile say it depends on hoe. Is removing the
dependency necessary?

3. There are 3328 ports or so in ports/devel, of those 1352 or so seem
to have multiple hyphens in them, including things such as
"py-repoze.what-pylons", "rpm-spec-mode.el" (both with 2 hyphens and a
dot), "p5-Test-Fixture-DBIC-Schema" (4 hyphens), "rubygem-file-tail",
"rubygem-ruby-debug-ide" (both 2 or more hyphons and also rubygems). So
I disagree that "we usually don't use hypens in the portname".

Also, the port for pkg-config is called "pkg-config". If I were
searching for pkg-config related ports, I would search for "pkg-config",
not "pkgconfig". Changing it seems unnecessary and makes life harder for
others, IMHO.

I ran portlint -Ac (v2.13.1) and it didn't produce a warning for this:

% portlint -Ac
WARN: Makefile: for new port, make $FreeBSD$ tag in comment section
empty, to make CVS happy.
FATAL: CVS: for safety, be sure to cleanup CVS directories before
importing the new port.
1 fatal error and 1 warning found.
%

(the CVS related warnings are of course not applicable because this has
already been committed)

4. Style issue which I'm willing to accept patches for, but don't have
time to work on at the moment.

5. Style issue which I'm willing to accept patches for, but don't have
time to work on at the moment.

Steve
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.16 (FreeBSD)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQEcBAEBAgAGBQJMt59bAAoJEPXPYrMgexuh5uAH/RO2LUaub7anCsoxX8dgxdCI
gseG8svnfRm01EE/peFpZCbDkyScZ+7Ay0beg+/Oesx4XC5umOs+lcYHn76/k/eg
HJ8dXK5jtnUE5SUSNKOleIuZ+Hw6OosU0QTbvX41ZBTYRd/E7die8lAkNqvh6daJ
oPXrWKEjZ6dgUsgoXk8U5C+qutTV6qzBHslFbSTLY+itgvbZTyXesXl9xlSVB3Wj
SVpknVjTMNEub8UBzPBtLococunt4HMriBMuQ2PDkbXi8Niyi5pis2oy5tglerGu
CBV21oFkR/43Vuq0pcu2ZdXp+C8B3SbhzkiIk+0VsAdOH/hEnvGBR8wtRSYcHAQ=
=sfLL
-----END PGP SIGNATURE-----