cvs commit: ports/databases Makefile ports/databases/py-flask-sqlalchemy Makefile distinfo pkg-descr pkg-plist

[Alexey Dokuchaev]

On Sat, Nov 27, 2010 at 02:01:36AM +0000, Philip M. Gollucci wrote:
> pgollucci    2010-11-27 02:01:35 UTC
> 
>   FreeBSD ports repository
> 
>   Modified files:
>     databases            Makefile 
>   Added files:
>     databases/py-flask-sqlalchemy Makefile distinfo pkg-descr 
>                                   pkg-plist 
>   Log:
>   Flask-SQLAlchemy adds support for SQLAlchemy to your Flask application.
>   
>   WWW:    http://pypi.python.org/pypi/Flask-SQLAlchemy
>   
>   PR:             ports/151626
>   Submitted by:   Olivier Duchateau <duchateau.olivier at gmail.com>

- Makefile is severely unindented
- PORTNAME is just disgustingly non-FreeBSDish [*]
- COMMENT should not be based on a verb instead of noun
- Missing tab in second RUN_DEPENDS line
- LICENSE should be better placed after COMMENT
- Port description contains style bug (tab after WWW:) and is identical to
  comment, ergo useless

[*] Original submission (which I've reviwed) did not contain this bug.
Why did you introduce it?

Please fix.

./danfe