cvs commit: ports/devel Makefile ports/devel/gdb Makefile distinfo pkg-descr pkg-plist ports/devel/gdb/files fbsd-threads.c patch-gdb-Makefile.in patch-gdb-amd64fbsd-nat.c patch-gdb-amd64fbsd-tdep.c patch-gdb-configure.tgt patch-gdb-i386bsd-nat.c patch-gdb-i386bsd-nat.h ...

Alexey Dokuchaev danfe at FreeBSD.org
Wed Nov 17 01:36:51 UTC 2010


On Tue, Nov 16, 2010 at 08:39:48PM +0000, Steven Kreuzer wrote:
>   Log:
>   GDB is a source-level debugger for Ada, C, C++, Objective-C, Pascal and
>   many other languages.  GDB can target (i.e., debug programs running on)
>   more than a dozen different processor architectures, and GDB itself can
>   run on most popular GNU/Linux, Unix and Microsoft Windows variants.

Nice!  Couple of minor nits:

- Spaces should be tab after MASTER_SITES=
- MASTER_SITE_SUBDIR=gdb/:gdb and :gdb suffix stuff in general seems to
  be copied from gdb6* ports maintained by mi at .  Looking at those, it is
  clear what suffix is for (hint: :gdbtk), but for this port I see no
  point in it; it just obfuscates the logic here
- VER= and MAN1= values are not properly indented

>   1.1       +6 -0      ports/devel/gdb/pkg-descr (new)

Tab after WWW: should be space.

>   1.1       +2 -0      ports/devel/gdb/pkg-plist (new)

Ugh.  Two-line plist file?  Why not use PLIST_FILES instead?

./danfe


More information about the cvs-all mailing list