cvs commit: ports/devel/p5-DateTime-Format-Epoch Makefile distinfo

Andrej Zverev az at freebsd.org
Mon Aug 30 07:51:12 UTC 2010


2010/8/30 Philippe Audéoud <jadawin at freebsd.org>:
> On Mon, 30 Aug 2010, Andrej Zverev wrote:
>
>> 2010/8/30 Philippe Audéoud <jadawin at freebsd.org>:
>> > On Mon, 30 Aug 2010, Andrej Zverev wrote:
>> >
>> >> On Sun, Aug 29, 2010 at 9:40 PM, Baptiste Daroussin <bapt at freebsd.org> wrote:
>> >> > bapt        2010-08-29 17:40:26 UTC
>> >> >
>> >> >  FreeBSD ports repository
>> >> >
>> >> >  Modified files:
>> >> >    devel/p5-DateTime-Format-Epoch Makefile distinfo
>> >> >  Log:
>> >> >  - Really update to 0.13
>> >> >  Approved by:    mentors (implicit)
>> >> >
>> >> >  Revision  Changes    Path
>> >> >  1.16      +1 -1      ports/devel/p5-DateTime-Format-Epoch/Makefile
>> >> >  1.12      +3 -3      ports/devel/p5-DateTime-Format-Epoch/distinfo
>> >> >
>> >>
>> >> Hello. I have a suggestion. Since author switched to Module::Build but
>> >>  for compatibility still using MM format, let's us switch to
>> >> Module::Build too and a little polishing.
>> >> Here you can find a patch for it.
>> >> http://sunner.semmy.ru/~az/p5-DateTime-Format-Epoch.diff
>> >> And if it's not hard for you please include Chagelog link into commit
>> >> messages in future. E.g Changes:
>> >> http://search.cpan.org/dist/AnyEvent-Twitter-Stream/Changes
>> >
>> >
>> > Hello,
>> >
>> > You mean add Changelog like you do ?
>> >
>> > http://www.freebsd.org/cgi/cvsweb.cgi/ports/textproc/p5-FormValidator-Lite/Makefile
>>
>> I am glad that you're so attentive. But I'm not asking to add your
>> text in the commit message if it came via GNATS as in my case. But
>> when you upgrade port by yourself that would be wonderful for p5-.
>> If you have any comments about my commits I'd be happy to hear them
>> and learn to do something better.
>> Am I right that my comments seem harsh, unfair? I suggest some sort of nonsense?
>
> I kindly suggest adding Changelog in all p5- commits. It's a quick
> way to know what's new on a p5- ports.
It's impossible. You can specify a p5-best practices in the Wiki, but
to force everyone to follow this..at least you need to start suggest
it to people.

> No, your comments are not harsh at all, some of them are really useful
> (like your patch for this commit) but you grumble a little bit to much.
Nice ;)
>
> IMHO, it's better to stop this useless thread. We heard your suggestion
> and we will add your patch.
Ok


More information about the cvs-all mailing list