cvs commit: ports/databases/kumofs Makefile distinfo pkg-plist ports/databases/kumofs/files kumofs-gateway.sh.in kumofs-manager.sh.in kumofs-server.sh.in

[Doug Barton]

There are numerous problems with these scripts. The first and most
important is that you apparently didn't test them with an up to date
ports tree because %%RC_SUBR%% is no longer expanded.

You also need to read
http://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/rc-scripts.html
for details on the following:

1. New scripts should not be added with the .sh extension
2. Scripts that run as a specific user must REQUIRE: LOGIN
3. Default variable assignments should use =, not :=
4. There should not be default assignments to empty variables, they
should be documented in the comments.
5. Since you're adding these all in the same port, it would be better
(although not mandatory) if you used REQUIRE instead of BEFORE. That
makes debugging easier.

Please correct these (especially the %%RC_SUBR%% issue) ASAP and bump
PORTREVISION.


Thanks,

Doug


On 04/26/10 06:39, Jun Kuriyama wrote:
> kuriyama    2010-04-26 13:39:48 UTC
> 
>   FreeBSD ports repository
> 
>   Modified files:
>     databases/kumofs     Makefile distinfo pkg-plist 
>   Added files:
>     databases/kumofs/files kumofs-gateway.sh.in 
>                            kumofs-manager.sh.in 
>                            kumofs-server.sh.in 
>   Log:
>   - Upgrade to 0.3.4.
>   
>   Revision  Changes    Path
>   1.4       +16 -6     ports/databases/kumofs/Makefile
>   1.3       +3 -3      ports/databases/kumofs/distinfo
>   1.1       +29 -0     ports/databases/kumofs/files/kumofs-gateway.sh.in (new)
>   1.1       +29 -0     ports/databases/kumofs/files/kumofs-manager.sh.in (new)
>   1.1       +31 -0     ports/databases/kumofs/files/kumofs-server.sh.in (new)
>   1.2       +4 -0      ports/databases/kumofs/pkg-plist
> 
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/databases/kumofs/Makefile.diff?&r1=1.3&r2=1.4&f=h
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/databases/kumofs/distinfo.diff?&r1=1.2&r2=1.3&f=h
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/databases/kumofs/files/kumofs-gateway.sh.in
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/databases/kumofs/files/kumofs-manager.sh.in
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/databases/kumofs/files/kumofs-server.sh.in
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/databases/kumofs/pkg-plist.diff?&r1=1.1&r2=1.2&f=h
> 



-- 

	... and that's just a little bit of history repeating.
			-- Propellerheads

	Improve the effectiveness of your Internet presence with
	a domain name makeover!    http://SupersetSolutions.com/