cvs commit: ports/Mk bsd.port.mk

Stanislav Sedov stas at FreeBSD.org
Tue Jun 9 15:47:46 UTC 2009


On Tue, 09 Jun 2009 17:11:09 +0200
Pav Lucistnik <pav at FreeBSD.org> mentioned:

> Stanislav Sedov píše v út 09. 06. 2009 v 19:06 +0400:
> 
> > >   - Fix COPYTREE_* macros not to change permissions and ownership on files, that
> > >     were already present in the target path
> > >   
> > >   Submitted by:   beech
> > 
> > This breaks a lot of ports at least on 7-STABLE. GNU CPIO changes permissions
> > to 0700 on the parent (and probably other) directoried in copy-out mode. After
> > this change these directories end up with permissions 0700 instead of 755 as
> > before. I think at least the part that changed permissions for directories
> > in the target dir to 0755 should be restored.
> > 
> > I've not checked if the HEAD cpio shows the same behaviour as GNU cpio yet.
> 
> This would certainly be clearly visible on the exp-run.  Can you send me
> a test-case?
>

The port that currently fails for me is ruby-locale2. But I'm able to reproduce
this with any port that uses copytree on 7.2. You can check this by hand
by running `cpio -dumpl * some_dir/` where some_dir already exists. You should
end up with permissions 0700 on that dir.

I'll try to dig deeper on evening.
 
> BTW find -exec chmod 755 is still part of the code...
> 

Yeah, but it only fix permissions on files that have been actually installed...

-- 
Stanislav Sedov
ST4096-RIPE
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/cvs-all/attachments/20090609/6fe4ebac/attachment.pgp


More information about the cvs-all mailing list