cvs commit: ports/mail/p5-qpsmtpd/files qpsmtpd.in

[Doug Barton]

Philip M. Gollucci wrote:
> pgollucci    2009-12-10 05:07:07 UTC
> 
>   FreeBSD ports repository
> 
>   Modified files:
>     mail/p5-qpsmtpd/files qpsmtpd.in 
>   Log:
>   Apply the following fixes to the rc.d script
>   - contains a typo
>   - does not daemonize the process by default
>   - does not check if the process is currently running
>   - does not provide output to STDOUT on start-up, shutdown, or when errors are encountered
>   
>   PR:             ports/141330  http://www.FreeBSD.org/cgi/query-pr.cgi?pr=141330
>   Submitted by:   Glen Barber <glen.j.barber at gmail.com>
>   
>   Revision  Changes    Path
>   1.2       +23 -2     ports/mail/p5-qpsmtpd/files/qpsmtpd.in
> 
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/mail/p5-qpsmtpd/files/qpsmtpd.in.diff?&r1=1.1&r2=1.2&f=h

I was going to install this port and try to come up with something a
little more constructive but it gave an odd dependency error so I
wasn't able to do so:

ERROR: the required Digest::SHA1 module is installed,
but is not an up-to-date version. at
lib/Mail/SpamAssassin/Util/DependencyInfo.pm line 294.


In any case, the rc.d script for this port has a lot of issues. As far
as I can see most of the script needlessly duplicates functionality
that is already in rc.d. In start_precmd, rather than using echo/exit
rc.d scripts should use the err() method. However most of what's in
there could be avoided by simply setting default values after
load_rc_config. The whole start_cmd could and probably should be
eliminated. The default command line should be set with command_args.
Likewise the stop_cmd is probably not necessary at all, you really
want to set command_interpreter instead.

Have a look at
http://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/rc-scripts.html
and the pages that it references. If you have any questions, feel free
to post on -ports or -rc, we'll be glad to help you.


hth,

Doug

-- 

	Improve the effectiveness of your Internet presence with
	a domain name makeover!    http://SupersetSolutions.com/