cvs commit: ports/www/lusca-head/files patch-ab patch-ac
Adrian Chadd
adrian at freebsd.org
Sun Dec 6 13:18:17 UTC 2009
I'm sorry for the drive-by commits like this - I had tested the port
locally and deployed it in production; I didn't realise there were so
many issues until after the commit.
I plan on bumping the port revision once I've established that all of
the post-install issues are fixed. I think they are now.
I apologies for the noise,
Adrian
2009/12/6 Gabor Kovesdan <gabor at freebsd.org>:
> Adrian Chadd escribió:
>>
>> adrian 2009-12-06 09:58:58 UTC
>>
>> FreeBSD ports repository (src committer)
>>
>> Added files:
>> www/lusca-head/files patch-ab patch-ac Log:
>> * Don't install the 'templates' error page directory. It isn't required.
>> * Default to "English" instead of "templates" in the configure script
>
> And what about the PORTREVISION bump, which is mandatory after changing the
> install process? You know that, don't you? It would be better if you asked a
> ports committer to help you and especially to *approve* your changes. Your
> recent commits are far from any of our conventions. I don't even dare to ask
> if you tested this on a ports tinderbox. With your src commit bit you are
> able to commit to the ports tree but it doesn't mean that you can do
> whatever you want. It isn't quite usual that doc/ports committers ignore
> rules and commit something wrong to src without approval but it is much more
> common that src committers commit awkward doc and *especially* ports
> changes. I would like to call the community attention (not just yours) that
> the highest importance of the src tree doesn't mean that src committers can
> do whatever they want in the doc and ports trees. We have our own
> conventions and rules here, please respect them and ask approval from a
> ports committer if you are unsure. There are a lot of helpful people, who
> are glad to help and review patches. I also do that when I have time.
>
> --
> Gabor Kovesdan
> FreeBSD Volunteer
>
> EMAIL: gabor at FreeBSD.org .:|:. gabor at kovesdan.org
> WEB: http://people.FreeBSD.org/~gabor .:|:. http://kovesdan.org
>
>
More information about the cvs-all
mailing list