cvs commit: src/sys/conf files src/sys/fs/tmpfs tmpfs.h tmpfs_subr.c tmpfs_vnops.c src/sys/i386/i386 bios.c src/sys/ia64/ia64 efi.c sal.c src/sys/libkern memcmp.c src/sys/mips/mips support.S src/sys/sys libkern.h

[Bjoern A. Zeeb]

On Tue, 23 Sep 2008, David E. O'Brien wrote:

Hi,

> obrien      2008-09-23 14:45:10 UTC
>
>  FreeBSD src repository
>
>  Modified files:
>    sys/conf             files
>    sys/fs/tmpfs         tmpfs.h tmpfs_subr.c tmpfs_vnops.c
>    sys/i386/i386        bios.c
>    sys/ia64/ia64        efi.c sal.c
>    sys/mips/mips        support.S
>    sys/sys              libkern.h
>  Added files:
>    sys/libkern          memcmp.c
>  Log:
>  SVN rev 183299 on 2008-09-23 14:45:10Z by obrien
>
>  The kernel implemented 'memcmp' is an alias for 'bcmp'.  However, memcmp
>  and bcmp are not the same thing.  'man bcmp' states that the return is
>  "non-zero" if the two byte strings are not identical.  Where as,
>  'man memcmp' states that the return is the "difference between the
>  first two differing bytes (treated as unsigned char values" if the
>  two byte strings are not identical.
>
>  So provide a proper memcmp(9), but it is a C implementation not a tuned
>  assembly implementation.  Therefore bcmp(9) should be preferred over memcmp(9).


Below you have changed a few places back to actually use bcmp instead
of memcmp.
I see lots of or more places in our kernel using memcmp. Are you
saying that they all need to be memcmp instead of bcmp and had been
unproper results so far or is the files down just a random collection
of memcmp->bcmp changes introduced with the same commit?


>  Revision  Changes    Path
>  1.1334    +1 -0      src/sys/conf/files
>  1.15      +1 -1      src/sys/fs/tmpfs/tmpfs.h
>  1.19      +1 -1      src/sys/fs/tmpfs/tmpfs_subr.c
>  1.24      +1 -1      src/sys/fs/tmpfs/tmpfs_vnops.c
>  1.75      +1 -1      src/sys/i386/i386/bios.c
>  1.6       +1 -1      src/sys/ia64/ia64/efi.c
>  1.16      +1 -1      src/sys/ia64/ia64/sal.c
>  1.1       +53 -0     src/sys/libkern/memcmp.c (new)
>  1.2       +0 -2      src/sys/mips/mips/support.S
>  1.59      +1 -6      src/sys/sys/libkern.h
>

-- 
Bjoern A. Zeeb              Stop bit received. Insert coin for new game.