NOPORTDOCS != NOPORTEXAMPLES != NOPORTDATA (Re: cvs commit: ports/databases/php4-rrdtool Makefile)

[Ion-Mihai Tetcu]

On Thu, 29 May 2008 23:23:33 +0200
Mathieu Arnold <mat at FreeBSD.org> wrote:

> +-Le 30/05/08 00:17 +0300, Ion-Mihai Tetcu a dit :
> | On Thu, 29 May 2008 20:57:04 +0000 (UTC)
> | Mathieu Arnold <mat at FreeBSD.org> wrote:
> | 
> |> mat         2008-05-29 20:57:03 UTC
> |> 
> |>   FreeBSD ports repository
> |> 
> |>   Modified files:
> |>     databases/php4-rrdtool Makefile 
> |>   Log:
> |>   Fix when NOPORTDOCS set
> |>   
> |>   Spotted By:     itetcu
> |>   
> |>   Revision  Changes    Path
> |>   1.6       +2 -0      ports/databases/php4-rrdtool/Makefile
> | 
> | No, please be careful:
> | 
> | We have 3 vars that control installation of "non-essential" files:
> | NOPORTDOCS, NOPORTEXAMPLES, NOPORTDATA
> | 
> | +.if !defined(NOPORTDOCS)
> |  post-install:
> |  	@${MKDIR} ${EXAMPLESDIR}
> |  	@${INSTALL_DATA} ${WRKSRC}/examples/* ${EXAMPLESDIR}
> |  	@${ECHO_MSG} "===> Examples installed in ${EXAMPLESDIR}."
> | +.endif
> | 
> | Since here you install examples you should test for NOPORTEXAMPLES.
> 
> Well, the plist has %%PORTDOCS%% so, I've added whatever was necessary to
> remain consistent. I can s/PORTDOCS/PORTEXAMPLES/ if you prefer.

Let's try to be consistent with the way things are supposed to work, ok?

So yes, please test for NOPORTEXAMPLES both in Makefile and change the
appropriate lines in pkg-plist.


Thanks,

-- 
IOnut - Un^d^dregistered ;) FreeBSD "user"
  "Intellectual Property" is   nowhere near as valuable   as "Intellect"
FreeBSD committer -> itetcu at FreeBSD.org, PGP Key ID 057E9F8B493A297B
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/cvs-all/attachments/20080529/32b386c6/signature.pgp