cvs commit: src/usr.bin/tar write.c

[Colin Percival]

cperciva    2008-05-23 05:07:22 UTC

  FreeBSD src repository

  Modified files:
    usr.bin/tar          write.c 
  Log:
  The value le->name cannot be NULL when we're freeing an entry in the
  hardlink table for two reasons: 1. If le->name is set to NULL, the
  structure le won't be inserted into the table; 2. Even if le somehow
  did manage to get into the table with le->name equal to NULL, we would
  die when we dereferenced le->null before we could get to the point of
  freeing the entry.
  
  Remove the unnecessary "if (le->name != NULL)" test and just free the
  pointer.
  
  Found by:       Coverity Prevent
  
  Revision  Changes    Path
  1.69      +1 -2      src/usr.bin/tar/write.c