cvs commit: ports/textproc/p5-Text-Markdown Makefile distinfo pkg-plist

[Henrik Brix Andersen]

On Sat, Mar 08, 2008 at 03:51:14PM -0300, Felippe de Meirelles Motta wrote:
> Em Sat, 8 Mar 2008 14:38:26 +0100
> Henrik Brix Andersen <brix at FreeBSD.org> escreveu:
> 
> > On Sat, Mar 08, 2008 at 12:53:50PM +0100, Gabor Kovesdan wrote:
> > > Henrik Brix Andersen escribió:
> > >> On Mon, Mar 03, 2008 at 09:39:14PM +0000, Gabor Kovesdan wrote:
> > >>   
> > >>> gabor       2008-03-03 21:39:14 UTC
> > >>> 
> > >>>   FreeBSD ports repository
> > >>> 
> > >>>   Modified files:
> > >>>     textproc/p5-Text-Markdown Makefile distinfo pkg-plist   Log:
> > >>>   - Update 1.0.13
> > >>>   - Better adjustement of dependencies
> > >>>   - Use PERL_CONFIGURE instead of PERL_MODBUILD
> > >>>     PR:             ports/121027
> > >>>   Submitted by:   Felippe de Meirelles Motta <lippemail at gmail.com>
> > >>>   Approved by:    maintainer
> > >>>     
> > >> 
> > >> This update breaks at least www/ikiwiki...
> > >> 
> > >> Somehow, Text::MultiMarkdown is now known as both
> > >> Text::MultiMarkdown and Text::Markdown on CPAN - (according to the
> > >> change log, the authors actually planned to "steal" the
> > >> Text::Markdown namespace for quite some time?) but it is not
> > >> compatible with the original Text::Markdown (which is what we had
> > >> as p5-Text-Markdown before this update).
> > >> 
> > >> The original version contained a Text::Markdown::Markdown() method,
> > >> whereas MultiMarkdown contains a Text::Markdown::markdown() method,
> > >> thus making the two incompatible (note the difference in
> > >> capitalization of the method name).
> > >> 
> > >> I suggest backing this update out, restoring the original
> > >> Text::Markdown functionality - and then perhaps committing this as
> > >> p5-Text-MultiMarkdown, where it IMO belongs.
> > >>   
> > > Ok, I'll look at this more deeply soon, thanks for noticing this
> > > issue!
> > 
> > I am currently running a patch [1] for www/ikiwiki which makes it work
> > with either version of the Text::Markdown package through the
> > ports tinderboxes.
> > 
> > Since other - non-FreeBSD users - will also be bitten by this change
> > in the Text::Markdown module, we might as well have it fixed properly.
> > 
> > Perhaps other consumers of the textproc/p5-Text-Markdown will need
> > similar patches.
> > 
> > Brix
> > 
> > [1]: http://people.freebsd.org/~brix/ports-patches/ikiwiki.diff
> 
> Hi brix,
> 
> May be i can send an downgrade to 1.0.5 and create an new port to
> MultiMarkdown with lastest version ? Or what is your suggestion ?

Well, even if we downgrade now we can't hold off on upgrading
textproc/p5-Text-Markdown forever. I suggest we keep the upgrade as-is
and instead examine the current consumers of textproc/p5-Text-Markdown
to make sure they all work with the new version.

I already committed a new version of www/ikiwiki with the
aforementioned patch.

> Thanks for report this issue!

No problem :)

Brix
-- 
Henrik Brix Andersen <henrik at brixandersen.dk>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 217 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/cvs-all/attachments/20080309/f7f9e5aa/attachment.pgp