cvs commit: ports/print/lilypond Makefile distinfo pkg-plist ports/print/lilypond/files patch-Documentation:usr:lilypond.tely patch-Documentation:usr:music-glossary.tely patch-mf:GNUMakefile pkg-install.in

[Alexey Dokuchaev]

On Thu, Jul 03, 2008 at 10:22:13PM +0000, Pietro Cerutti wrote:
> gahr        2008-07-03 22:22:13 UTC
> 
>   FreeBSD ports repository
> 
>   Modified files:
>     print/lilypond       Makefile distinfo pkg-plist 
>   Removed files:
>     print/lilypond/files patch-Documentation:usr:lilypond.tely 
>                          patch-Documentation:usr:music-glossary.tely 
>                          patch-mf:GNUMakefile pkg-install.in 
>   Log:
>   - Update to 2.11.47

Thanks!  Couple of observations (style, mostly):

- You forgot to mention that you've taken maintainership in commit log
- OPTIONS entry should not use verbs in third person form
- You've dropped USE_BISON and added explicit bdep, can you elaborate on
  why was that needed?
- Some knobs are set to `YES', while some to `yes', which looks
  inconsistent
- Suporfluous tab after CONFIGURE_ENV+=, oddly placed quotes in that
  line as well
- Lots of spaces that should be tabs along the Makefile
- post-extract: target looks sintactically overly complicated; similar
  actions performed for number of linux games (e.g. linux-ut2003-demo)
  for extracting embedded source tarball are much easier to read

./danfe