cvs commit: src/sys/nfsclient nfs_socket.c

Alfred Perlstein alfred at freebsd.org
Thu Jan 10 17:03:30 PST 2008


* John Baldwin <jhb at FreeBSD.org> [080110 15:33] wrote:
> jhb         2008-01-10 23:36:00 UTC
> 
>   FreeBSD src repository
> 
>   Modified files:
>     sys/nfsclient        nfs_socket.c 
>   Log:
>   Pass curthread to various socket routines (socreate(), sobind(), and
>   soconnect()) instead of &thread0 when establishing a connection to the NFS
>   server.  Otherwise inconsistent credentials may be used when setting up
>   the NFS socket.

I'm not sure, but I think this may be a regression, I seem to recall
that a long time ago it was switched to &thread0 because otherwise
certain operations can fail due to curthread not running as root.

Rev 1.73 of this file might have some clues.

I think something weird with ipfw+uid rules can happen with curthread
rather than thread0, but I might be mistaking 1.73 for some other change.

>   
>   MFC after:      1 week
>   Reviewed by:    rwatson
>   
>   Revision  Changes    Path
>   1.156     +1 -1      src/sys/nfsclient/nfs_socket.c

-- 
- Alfred Perlstein


More information about the cvs-all mailing list