cvs commit: ports/sysutils/cdrtools-devel Makefile pkg-plist ports/sysutils/cdrtools-devel/files patch-libsiconv-sic_nls.c

Doug Barton dougb at FreeBSD.org
Mon Feb 18 14:06:39 PST 2008


Marius Strobl wrote:
> marius      2008-02-18 21:48:57 UTC
> 
>   FreeBSD ports repository (src committer)
> 
>   Modified files:
>     sysutils/cdrtools-devel Makefile pkg-plist 
>   Added files:
>     sysutils/cdrtools-devel/files patch-libsiconv-sic_nls.c 
>   Log:
>   Fix `mkisofs -input-charset`:
>   - The configure script adds dependencies on libiconv and libintl when
>     found so set USE_GETTEXT and USE_ICONV accordingly. If these libraries
>     are not yet installed, these dependencies can be turned off by defining
>     WITHOUT_NLS. There's no easy way to force these dependencies off as
>     the configure script doesn't offer such a knob and modifying its tests
>     is not allowed.

I'm confused, why is modifying the tests not allowed?

Doug

>   - When setting USE_GETTEXT and USE_ICONV, also add OSDEFS to the MAKE_ENV
>     as a hack to pass -I${LOCALBASE}/include as CPPFLAGS so the installed
>     iconv.h is found.
>   - Install the charset conversion tables.
>   - Set ${INS_BASE} to ${LOCALBASE} in DEFAULTS/Defaults.freebsd so the
>     path constructed by libsiconv and mkisofs points to the installed
>     conversion tables.
>   - Fix a bug that caused the 'iconv:' prefix not to be stripped from the
>     implied '-output-charset' when the conversion tables are not found or
>     '-input-charset' is used with the 'iconv:' prefix.
>   
>   Submitted by:   jkim
>   Approved by:    netchild
>   
>   Revision  Changes    Path
>   1.88      +25 -6     ports/sysutils/cdrtools-devel/Makefile
>   1.1       +45 -0     ports/sysutils/cdrtools-devel/files/patch-libsiconv-sic_nls.c (new)
>   1.17      +49 -0     ports/sysutils/cdrtools-devel/pkg-plist
> 
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/sysutils/cdrtools-devel/Makefile.diff?&r1=1.87&r2=1.88&f=h
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/sysutils/cdrtools-devel/files/patch-libsiconv-sic_nls.c
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/sysutils/cdrtools-devel/pkg-plist.diff?&r1=1.16&r2=1.17&f=h
> 


-- 

     This .signature sanitized for your protection


More information about the cvs-all mailing list