cvs commit: src/lib/libc/locale utf8.c

[John-Mark Gurney]

Andrey Chernov wrote this message on Fri, Oct 26, 2007 at 23:00 +0400:
> On Sat, Oct 27, 2007 at 12:54:21AM +0800, Rong-en Fan wrote:
> > As for RELENG_7 and HEAD, I'm not 100% sure whether we should restore
> > the compatibility as 1) 7.0 is not released yet, 2) we don't promise
> > anything in
> > HEAD branch. However, if most people think get rid of inline stuffs and
> > have libc compatibility are nice, then we do the same for those two branches.
> 
> Although standard permits functions only, I object against permanent 
> removing inlines from ctype. Almost every system have them as macros or 
> inlines and not as function calls, and it is for reason. Ctype functions 
> are very inside-loop-intensive, and not speeding them up may slowdown apps 
> which do intensive text processing.

Have you done benchmarks to prove that making it a function will slow
it down significantly?  Things have changed over the years....

-- 
  John-Mark Gurney				Voice: +1 415 225 5579

     "All that I will do, has been done, All that I have, has not."