cvs commit: src/sys/kern kern_lock.c src/sys/sys lockmgr.h

Attilio Rao attilio at freebsd.org
Sat Nov 24 12:19:40 PST 2007


2007/11/24, Robert Watson <rwatson at freebsd.org>:
> On Sat, 24 Nov 2007, Attilio Rao wrote:
>
> > attilio     2007-11-24 04:22:28 UTC
> >
> >  FreeBSD src repository
> >
> >  Modified files:
> >    sys/kern             kern_lock.c
> >    sys/sys              lockmgr.h
> >  Log:
> >  transferlockers() is a very dangerous and hack-ish function as waiters
> >  should never be moved by one lock to another.
> >  As, luckily, nothing in our tree is using it, axe the function.
> >
> >  This breaks lockmgr KPI, so interested, third-party modules should update
> >  their source code with appropriate replacement.
> >
> >  Ok'ed by: ups, rwatson
>
> "Ok'd by" doesn't generally seem to be a convention for FreeBSD commit
> messages--I'd suggest "discussed with" which makes it seem a bit less like
> approval, which is generally captured with "approved by".

Though I saw it used several time, ok, thanks.

Attilio


-- 
Peace can only be achieved by understanding - A. Einstein


More information about the cvs-all mailing list