cvs commit: src/sys/kern kern_kse.c

[M. Warner Losh]

In message: <20071115194710.L82897 at fledge.watson.org>
            Robert Watson <rwatson at FreeBSD.org> writes:
: 
: On Thu, 15 Nov 2007, Julian Elischer wrote:
: 
: >>> "no matter how small the change, use diff + patch to move it across."
: >> 
: >> After applying the patch on your commit machine, is it too difficult to 
: >> actually retest before committing?  This would catch the broken commit 
: >> before it becomes a Tinderbox issue.
: >> 
: >> Seems to be a QA problem on your part.
: >
: > yes.. but I can't do a compile from my mac. (my commit machine). The answer 
: > is to be rigorous about how I move the patch from the build machine to the 
: > commit machine.
: >
: > This is a temporary situation. new infrastructure will let me commit from my 
: > build machine again.
: 
: I find having a copy of Parallels (or VMWare) around very useful for precisely 
: this situation -- it means that even when I have only the Mac around I can 
: easily do a local test build.  The various VM packages certainly have their 
: limitations, but they're far better than nothing.

I've always found that no matter how much testing i do, sometimes
accidents happen.  The only way to be sure is to test, commit and then
checkout in a clean tree the change you made and test again...

Warner