cvs commit: src/sys/dev/em if_em.c
pyunyh at gmail.com
Fri May 25 01:22:07 UTC 2007
On Thu, May 24, 2007 at 06:11:11PM +0000, Jack F Vogel wrote:
> jfv 2007-05-24 18:11:11 UTC
> FreeBSD src repository
> Modified files:
> sys/dev/em if_em.c
> Fix for PR 112937, thanks to Ruslan Ermilov. I am still
> a bit confused how the 'link flap' was connected to the
> 'get' rather than 'set' address, but this seems the right
> thing to do here.
Thanks for the fix. The bug was introduced by me and it was just
a hack to suppress hardware reinitialization.
I know lots of ethernet drivers do this kind of hardware
reinitailization whenever alias addresses are added. I guess we
should reinitialize the hardware only when it's absolutely required.
Fixing ether_ioctl() to invoke if_init only when the interface is not
running would remove the hack but I'm not sure how it would affect
configuraing multicasting filters in ethernet drivers.
More information about the cvs-all