cvs commit: src/sys/kern uipc_syscalls.c

[Robert Watson]

On Tue, 22 May 2007, Dag-Erling Smørgrav wrote:

> Robert Watson <rwatson at FreeBSD.org> writes:
>> Alfred Perlstein <alfred at freebsd.org> writes:
>>> Is this the same bug that used to be in sendfile but got corrected some 
>>> years back?
>> Dunno, but it sounds like we really need a comprehensive set of edge-case 
>> tests for sendfile.
>
> This was not an edge case.  The edge case (no offset, no length, no header) 
> was the one that worked; it was the non-trivial case (non-zero offset, 
> explicit length, non-empty header) that was broken.  Nobody noticed because 
> existing code (Apache, ftpd) only exercises the edge case.

I stand corrected. :-)

Robert N M Watson
Computer Laboratory
University of Cambridge