cvs commit: src Makefile.inc1

Alexander Leidinger Alexander at Leidinger.net
Wed May 16 09:29:17 UTC 2007


Quoting Dag-Erling Smørgrav <des at des.no> (from Wed, 16 May 2007  
10:25:14 +0200):

> Alexander Leidinger <Alexander at Leidinger.net> writes:
>> Dag-Erling Smørgrav <des at des.no> writes:
>> > Alexander Leidinger <Alexander at Leidinger.net> writes:
>> > > The original code hat it before, but you CD into DESTDIR, so it is not
>> > > necessary anymore.
>> > Unless someone goofs and adds an absolute path to ObsoleteFiles.inc...
>> > which is why I very deliberately left "${DESTDIR}/" in front of the path
>> > in the rm command, although I could probably replace it with "./".
>> That would make it more consistent.
>
> No, wait, there is another reason I had forgotten: the path passed to rm
> is shown to the user, so it should be the full path.

Ah, yes... ok, why not remove the cd DESTDIR and use DESTDIR instead  
of the ./? Or add a comment explaining why DESTDIR is used for the rm.

Bye,
Alexander.

-- 
Bombeck's Rule of Medicine:
	Never go to a doctor whose office plants have died.

http://www.Leidinger.net    Alexander @ Leidinger.net: PGP ID = B0063FE7
http://www.FreeBSD.org       netchild @ FreeBSD.org  : PGP ID = 72077137


More information about the cvs-all mailing list