cvs commit: src Makefile.inc1

[Dag-Erling Smørgrav]

Alexander Leidinger <Alexander at Leidinger.net> writes:
> Dag-Erling Smorgrav <des at FreeBSD.org> writes:
> > Alexander Leidinger <Alexander at Leidinger.net> writes:
> > > Why did you remove the echo?
> > which echo?  about schg?  it was completely bogus.
> Yes. I don't think so, please explain.

It would show up incorrectly if you declined to remove a file.

> > feel free to re-add it, but only if you also add logic to check whether
> > the file actually has the schg flag set before running chflags.
> In the current code it doesn't make sense, and the wording can be
> changed to tell that it will remove schg, in case this flag is set. As
> you did the change and I don't have time to commit such a change when
> I'm back at home (the place where I can make commits), would you
> please add the echo again?

That would mean an extra line of output for every single file...

> > > Why do you redirect stderr of chflags to /dev/null?
> > because chflags will complain if your /usr is on a file system which
> > does not support flags, such as NFS or ZFS.
> But it also removes any other failure message. A more sensible
> approach would be to replace the redirection with a "grep -v".

No, a more sensible approach would be to only remove schg if it is set.

> > >  - bug(?): ${DESTDIR} in the rm line
> > no, this is intentional, and in fact the original code had it too.
> The original code hat it before, but you CD into DESTDIR, so it is not
> necessary anymore.

Unless someone goofs and adds an absolute path to ObsoleteFiles.inc...
which is why I very deliberately left "${DESTDIR}/" in front of the path
in the rm command, although I could probably replace it with "./".

DES
-- 
Dag-Erling Smørgrav - des at des.no