cvs commit: src/sys/netinet tcp_output.c

[Andre Oppermann]

Julian Elischer wrote:
> Rui Paulo wrote:
>> At Fri, 11 May 2007 02:12:53 +0200,
>> Andre Oppermann wrote:
>>> Rui Paulo wrote:
>>>> At Fri, 11 May 2007 01:17:09 +0200,
>>>> Andre Oppermann wrote:
>>>>> Andre Oppermann wrote:
>>>>>> andre       2007-05-10 23:11:29 UTC
>>>>>>
>>>>>>   FreeBSD src repository
>>>>>>
>>>>>>   Modified files:
>>>>>>     sys/netinet          tcp_output.c   Log:
>>>>>>   Fix an incorrect replace of a timer reference made during the 
>>>>>> TCP timer
>>>>>>   rewrite in rev. 1.132.  This unmasked yet another bug that 
>>>>>> causes certain
>>>>>>   connections to get indefinately stuck in LAST_ACK state.
>>>>>>     Revision  Changes    Path
>>>>>>   1.135     +1 -1      src/sys/netinet/tcp_output.c
>>>>> Pointy hat to:    andre
>>>>>
>>>>> Fix for the other masked bug(s) is in the works.
>>>> Does this fix the bug related to rfc1323?
>>>> If not, is it in the works?
>>> No, this doesn't fix it.  Which bug about rfc1323 are referring to?
>>
>> I sent you two tcpdump's regarding to an HTTP connection that got
>> stuck after a few bytes were transfered. One with RFC1323 enable and
>> another one without it.
>> Disabling RFC1323 sysctl made the connection work flawlessly.
>> The host I'm communicating with is on the same network segment.
>>
>> Did you recieve the dumps?
> 
> 
> This may be one of the ones I sent to you andre.. In the one we saw,
> the scaling is done wrong if the other end wants to scale by 9 and set a 
> window size of 1.
> 
> FreeBSD thinks it has a window size of 1 instead of 1<<9.
> 
> I thought this was fixed in -current but it has the same symptoms as 
> what we see in 6.

I'll look into it tomorrow.  Too tired now.

-- 
Andre