cvs commit: src/usr.bin/tar write.c

Alexander Leidinger Alexander at Leidinger.net
Fri May 4 12:16:09 UTC 2007


Quoting Colin Percival <cperciva at freebsd.org> (from Thu, 03 May 2007  
10:20:22 -0700):

> Tim Kientzle wrote:
>> I wonder if it would be simpler to set non-zero exit only
>> if this is the first path returned from tree_next() (which
>> should be the path given on the command line).  That
>> would avoid the headache of having to perform a textual
>> path comparison.
>>
>> A simple flag to indicate if this is the first time
>> through the loop should suffice, I think.
>
> Hmm... I considered this, but I wasn't sure if there were any edge
> cases where the first path returned by tree_next might not be the
> path passed to tree_open; so I decided to take the route which I
> knew would always work.

What if someone gives more than one path to tar?

Bye,
Alexander.

-- 
Put no trust in cryptic comments.

http://www.Leidinger.net    Alexander @ Leidinger.net: PGP ID = B0063FE7
http://www.FreeBSD.org       netchild @ FreeBSD.org  : PGP ID = 72077137


More information about the cvs-all mailing list