cvs commit: ports/www/apache13-modperl Makefile pkg-plist ports/www/apache13-modperl/files apache.in apache.sh

[Doug Barton]

Pav Lucistnik wrote:
> pav         2007-03-14 20:21:31 UTC
> 
>   FreeBSD ports repository
> 
>   Modified files:
>     www/apache13-modperl Makefile pkg-plist 
>   Added files:
>     www/apache13-modperl/files apache.in 
>   Removed files:
>     www/apache13-modperl/files apache.sh 
>   Log:
>   - Fix rc script to have overridable apache_flags and apache_pidfile
>   
>   PR:             ports/104465  http://www.FreeBSD.org/cgi/query-pr.cgi?pr=104465
>   Reported by:    Andrey Alakozov <aa29 at mail.ru>
>   Submitted by:   Volker <volker at vwsoft.com>
>   Approved by:    maintainer timeout (apache; 5 months)
>   
>   - While here, modernize USE_RC_SUBR usage
>   
>   Revision  Changes    Path
>   1.18      +2 -8      ports/www/apache13-modperl/Makefile
>   1.1       +32 -0     ports/www/apache13-modperl/files/apache.in (new)
>   1.4       +0 -32     ports/www/apache13-modperl/files/apache.sh (dead)
>   1.7       +0 -1      ports/www/apache13-modperl/pkg-plist
> 
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/www/apache13-modperl/Makefile.diff?&r1=1.17&r2=1.18&f=h
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/www/apache13-modperl/files/apache.in
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/www/apache13-modperl/files/apache.sh
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/www/apache13-modperl/pkg-plist.diff?&r1=1.6&r2=1.7&f=h

The changes to the Makefile and plist look good, thanks! Two problems 
with the rc.d script though. First, this:

apache_flags="${apache_flags=''}"

Is not necessary, or desirable. Second, since httpd is going to run as 
user www, the BEFORE statement should be dropped, and the REQUIRE 
should be changed to LOGIN.

I'm happy to make these changes if no one objects.

Doug

-- 

     This .signature sanitized for your protection