cvs commit: src/usr.sbin/pkg_install/lib deps.c

Nate Lawson nate at root.org
Tue Jun 19 22:16:29 UTC 2007


Kris Kennaway wrote:
> On Tue, Jun 19, 2007 at 02:08:41PM -0400, Coleman Kane wrote:
>> On Tue, 2007-06-19 at 17:54 +0200, Pav Lucistnik wrote:
>>> Coleman Kane p????e v ??t 19. 06. 2007 v 11:51 -0400:
>>>> On Mon, 2007-06-18 at 22:49 +0000, Pav Lucistnik wrote:
>>>>> pav         2007-06-18 22:49:13 UTC
>>>>>
>>>>>   FreeBSD src repository (doc,ports committer)
>>>>>
>>>>>   Modified files:
>>>>>     usr.sbin/pkg_install/lib deps.c 
>>>>>   Log:
>>>>>   - Replace rather inefficient bubble sort with a recursive depth-first search.
>>>>>     This speeds up registration of packages considerably.
>>>>>   - style(9) police welcome!
>>>>>   
>>>>>   PR:             bin/112630
>>>>>   Submitted by:   Stephen Montgomery-Smith <stephen at cauchy.math.missouri.edu>
>>>>>   Tested by:      bento i386 experimental run
>>>>>   MFC after:      14 days
>>>>>   
>>>>>   Revision  Changes    Path
>>>>>   1.12      +111 -65   src/usr.sbin/pkg_install/lib/deps.c
>>>>>
>>>> Is this by any chance connected to why many of my gnome2 dependencies
>>>> would take longer to register than to compile?
>>> Are you observing slowdown registering ports with this patch?
>>>
>> I don't think so. I don't even know if I have the latest sources for
>> pkg_install down yet.
>>
>> I was actually referring to my experience since the x.org modularization
>> that ended up (I think) causing so many dependencies on some packages
>> that registration was awfully slow. I wanted to know if this patch was
>> expected to fix that problem.
> 
> Yes, precisely so.

Excellent!  Thanks for working on this, Pav.

-- 
Nate


More information about the cvs-all mailing list