cvs commit: ports/devel/libdasm Makefile distinfo pkg-plist

[Rong-En Fan]

On Sat, Jun 16, 2007 at 04:31:40PM -0400, Kris Kennaway wrote:
> On Sat, Jun 16, 2007 at 10:27:47PM +0200, Erwin Lansing wrote:
> > On Sat, Jun 16, 2007 at 04:21:30PM -0400, Kris Kennaway wrote:
> > > On Sat, Jun 16, 2007 at 07:25:46PM +0000, Rong-En Fan wrote:
> > > > rafan       2007-06-16 19:25:46 UTC
> > > > 
> > > >   FreeBSD ports repository
> > > > 
> > > >   Modified files:
> > > >     devel/libdasm        Makefile distinfo pkg-plist 
> > > >   Log:
> > > >   - Update to 1.5 [1]
> > > >   - Replace deprecated variable: INSTALLS_SHLIB
> > > >   - Use PORTDOCS to simplify pkg-plist
> > > >   
> > > >   PR:            ports/113760 [1]
> > > >   Submitted by:  Antoine Brodin <antoine.brodin at laposte.net> (maintainer)
> > > >   Approved by:   Antoine Brodin <antoine.brodin at laposte.net> (maintainer)
> > > 
> > > It's reasonable to assume that changes submitted by a maintainer are
> > > self-approved, so the duplication isn't necessary :)
> > > 
> > It took me a while to parse it as well and wanted to send the same
> > message, but I figured that the submitted line goes with [1] and the
> > approved with the other two.  The message seems right afterall, though
> > confusing at best :-)
> 
> Ah, OK.  In this case we typically do something like
> 
> Log:
>  - Update to 1.5 [1]
>  - Replace deprecated variable: INSTALLS_SHLIB [2]
>  - Use PORTDOCS to simplify pkg-plist [2]
> 
>  PR:            ports/113760 [1]
> 
> Submitted by:  Antoine Brodin <antoine.brodin at laposte.net> (maintainer) [1]
> Approved by:   Antoine Brodin <antoine.brodin at laposte.net> (maintainer) [2]
> 
> to disambiguate.  I guess it's not important in this case though.

Sorry for the confusion. Yes, the approval is for those 
parts indicated by [2]. Will make it more clear next time.

Regards,
Rong-En Fan
> 
> Kris